Changes between Initial Version and Version 1 of Ticket #235
- Timestamp:
- 30 Apr 2019, 10:12:46 (6 years ago)
Legend:
- Unmodified
- Added
- Removed
- Modified
-
Ticket #235 – Description
initial v1 1 1 1.) The following context derivation for the TS significant coefficient group flag seems to be off by 1. 2 2 3 {{{ 3 4 unsigned sigLeft = unsigned( int( CGPosX - 1 ) > 0 ? ... 4 5 unsigned sigAbove = unsigned( int( CGPosY - 1 ) > 0 ? ... 5 6 }}} 6 7 7 8 Specifically, ( CGPosX - 1 ) > 0 and ( CGPosY - 1 ) > 0. Shouldn’t these just be CGPos > 0? As it is now, this code ignores the first row/column of context. … … 9 10 10 11 2.) The following quantization selection logic (dependent quant vs. regular quant) for mtsIdx ==1 should only apply to luma, not chroma. 11 12 {{{ 12 13 if( tu.cs->slice->getDepQuantEnabledFlag() && tu.mtsIdx != 1 ) 14 }}}