id	summary	reporter	owner	description	type	status	priority	milestone	component	version	resolution	keywords	cc
374	JVET-O0055 with DMVR SAD Doubled	bheng		"The BDOF disable threshold in the VTM code

    bioEnabledThres = 8 * (dy >> 1) * dx;

appears to match the threshold in the text:

    (((sbHeight >> 2) * (sbWidth >> 2) * bdofBlkDiffThres) >> 5)

Unfortunately,the SAD value returned from xDMVRCost( ) in the VTM code appears to be doubled relative to what is specified in the draft text, Section 8.5.3.3. 

Specifically, see function xGetSAD_NxN_SIMD() where the SAD is doubled at the following line:

    uiSum <<= iSubShift;

Assuming it is desired to keep the behavior of the code, the threshold in the draft text probably needs to be reduced by a factor of 2 to give the same behavior.


"	defect	closed	minor	VVC D6 vD	spec	VVC D6 vC	fixed		ksuehring bbross XiangLi fbossen jvet@…