Opened 4 years ago

Closed 2 years ago

#1227 closed enhancement (worksforme)

Issue on explicit weighted prediction(related to #1215 )

Reported by: swlim Owned by:
Priority: minor Milestone:
Component: VTM Version:
Keywords: Cc: cjianle@…, frank.bossen@…, xlxiangli@…, jvet@…, ksuehring, XiangLi, fbossen


In VTM, there is unnecessary condition (related to #1225).

In addWeightUni(..), two variables are set to as follows:

const int shiftNum = std::max<int>(2, (IF_INTERNAL_PREC - clipBD));
const int shift = wp0[compID].shift + shiftNum;

Therefore, the value of the variable shift is always larger than 1, it is suggested that the following code

const int  round = (shift > 0) ? (1 << (shift - 1)) : 0;

should be replaced by

const int  round = 1 << (shift - 1);

Change history (2)

comment:1 Changed 4 years ago by fbossen

  • Type changed from defect to enhancement

comment:2 Changed 2 years ago by fbossen

  • Resolution set to worksforme
  • Status changed from new to closed
Note: See TracTickets for help on using tickets.