Opened 4 years ago

Closed 4 years ago

#1093 closed defect (fixed)

Bugs in BPSEI and PTSEI

Reported by: kazui Owned by:
Priority: major Milestone: VTM-10.1
Component: VTM Version: VTM-9.0
Keywords: BP SEI, PT SEI Cc: ksuehring, XiangLi, fbossen, jvet@…


1) Signalling of bp_max_sublayers_minus1 in BPSEI

Signalling of bp_max_sublayers_minus1 is unconditional both in the text and SEIReader::xReadSEIPictureTiming(). However, it is conditioned the value of cpb_removal_delay_deltas_present_flag in SEIWriter::xWriteSEIBufferingPeriod().

The following two lines in SEIWriter::xWriteSEIBufferingPeriod() should be moved from inside the if-statement " if (sei.m_cpbRemovalDelayDeltasPresentFlag) {..}" to before signalling bp_cpb_cnt_minus1.

CHECK (sei.m_bpMaxSubLayers < 1, "bp_max_sub_layers_minus1 must be > 0");

WRITE_CODE( sei.m_bpMaxSubLayers - 1, 3, "bp_max_sub_layers_minus1" );

2) For-loop for pt_du_common_cpb_removal_delay_increment_minus1[i] and pt_du_cpb_removal_delay_increment_minus1[i][j] in PTSEI

The end-value of the for-loops for pt_du_common_cpb_removal_delay_increment_minus1[i] (in SEIWriter::xWriteSEIPictureTiming() and SEIReader::xParseSEIPictureTiming()) does not match those in the text.

" for( int i = temporalId; i < bp.m_bpMaxSubLayers - 1; i ++ ) " shall be " for( int i = temporalId; i <= bp.m_bpMaxSubLayers - 1; i ++ ) ".

Similar modification shall also be applied to pt_du_cpb_removal_delay_increment_minus1[i][j].

3) Initialization of pt_sublayer_delays_present_flag[ 0 ] when bp_max_sublayers_minus1 is equal to 0 in PTSEI

The value of pt_sublayer_delays_present_flag[ bp_max_sublayers_minus1 ] is set to 1 in the text. It is asserted that this Initialization should be applied also to the case bp_max_sublayers_minus1 equal to 0.

However, pt_sublayer_delays_present_flag[ 0 ] is not initialized to 1 when bp_max_sublayers_minus1 is equal to 0 both in SEIWriter::xWriteSEIPictureTiming() and SEIReader::xParseSEIPictureTiming().

MR is in preparation.

Attachments (1)

vtm-9.0_#1093.diff (1.4 KB) - added by kazui 4 years ago.

Download all attachments as: .zip

Change history (4)

Changed 4 years ago by kazui

comment:1 Changed 4 years ago by kazui

Diff file is attached, instead of issuing MR.

comment:2 Changed 4 years ago by ksuehring

  • Milestone VTM-9.1 deleted

comment:3 Changed 4 years ago by XiangLi

  • Milestone set to VTM-10.1
  • Resolution set to fixed
  • Status changed from new to closed
Note: See TracTickets for help on using tickets.