#1101 closed defect (fixed)

Redundant condition related to LFNST

Reported by: T.Hashimoto Owned by:
Priority: minor Milestone: VVC D10
Component: spec Version: VVC D9 vB
Keywords: Cc: ksuehring, bbross, XiangLi, fbossen, jvet@…

Description

In 8.7.4.1 of JVET-R2001-v10.doc:

The variables nonZeroW and nonZeroH are derived as follows:
–	If ApplyLfnstFlag is equal to 1 and nTbW is greater than or equal to 4 and nTbH is greater than or equal to 4, the following applies:

Above size restriction part "and both nTbW and nTbH are greater than or equal to 4" is redundant since ( lfnst_idx > 0 && cIdx = = 0 ) check in ApplyLfnstFlag already covered the case.
Thus I'd like to suggest to remove "and both nTbW and nTbH are greater than or equal to 4" as follows

The variables nonZeroW and nonZeroH are derived as follows:
–	If ApplyLfnstFlag is equal to 1, the following applies:

Change history (4)

comment:1 Changed 15 months ago by bbross

  • Milestone set to VVC D10
  • Version set to VVC D9 vB

comment:2 Changed 15 months ago by bbross

Good catch, I assume the check in the same section above is redundant as well?

When ApplyLfnstFlag is equal to 1, transform_skip_flag[ xTbY ][ yTbY ][ cIdx ] is equal to 0 and both nTbW and nTbH are greater than or equal to 4, the following applies:
– The variables predModeIntra, nLfnstOutSize, log2LfnstSize, nLfnstSize, and nonZeroSize are derived as follows:
...

comment:3 Changed 15 months ago by T.Hashimoto

Yes, I agree. It should be redundant.
A suggested fix:

When ApplyLfnstFlag is equal to 1 and transform_skip_flag[ xTbY ][ yTbY ][ cIdx ] is equal to 0, the following applies:
– The variables predModeIntra, nLfnstOutSize, log2LfnstSize, nLfnstSize, and nonZeroSize are derived as follows:

comment:4 Changed 15 months ago by bbross

  • Resolution set to fixed
  • Status changed from new to closed

Will be fixed in JVET-S2001-vA.

Note: See TracTickets for help on using tickets.