Opened 9 months ago

Closed 8 months ago

#1116 closed defect (fixed)

In 8.4.5.2.6 of JVET-R2001.doc, whRatio should be set equal to Abs(Log2(nH/nW)) when nH is greater than nW

Reported by: annci Owned by:
Priority: blocker Milestone: VVC D10
Component: spec Version: VVC D9 vB
Keywords: Cc: ksuehring, bbross, XiangLi, fbossen, jvet@…

Description

In 8.4.5.2.6 of JVET-R2001.doc:
if all of the following conditions are true, predModeIntra is set equal to (predModeIntra - 67).

  • nH is greater than nW
  • predModeIntra is less than or equal to 66
  • predModeIntra is greater than (whRatio > 1)? (60 - 2*shRatio) : 60

Because whRatio is set equal to Abs(Log2(nW/nH)), whRatio can NOT be greater than 1 when nH is greater than nW. I think whRatio is set equal to Abs(Log2(nH/nW)) in this case.

Change history (5)

comment:1 Changed 8 months ago by bbross

  • Milestone set to VVC D10
  • Version set to VVC D9 vB

Thanks for reporting.

Can someone confirm the suggested fix?

comment:2 Changed 8 months ago by bbross

  • Priority changed from minor to blocker

comment:3 Changed 8 months ago by deluxan

  • Resolution set to invalid
  • Status changed from new to closed

Since log2(W/H) = -log2(H/W), it is mathematically guaranteed that

abs(log2(W/H)) = abs(log2(H/W)).

Therefore, whRatio can be greater than one. For example, for nW = 4 and nH = 16, we have abs(log2(4/16)) = abs(log2(1/4)) = abs(-2) = 2.

In my opinion, the spec is correct.

comment:4 Changed 8 months ago by bbross

  • Resolution invalid deleted
  • Status changed from closed to reopened

comment:5 Changed 8 months ago by bbross

  • Resolution set to fixed
  • Status changed from reopened to closed

Fixed in JVET-S2001-v7 as agreed in the meeting.

Note: See TracTickets for help on using tickets.