Opened 4 years ago
Closed 4 years ago
#1141 closed defect (fixed)
Missing subtraction for sps_max_num_merge_cand_minus_max_num_gpm_cand
| Reported by: | hbteo | Owned by: | |
|---|---|---|---|
| Priority: | minor | Milestone: | VTM-10.0 |
| Component: | VTM | Version: | VTM-9.0 |
| Keywords: | Cc: | ksuehring, XiangLi, fbossen, jvet@… |
Description
Spec description:
The value of sps_max_num_merge_cand_minus_max_num_gpm_cand shall be in the range of 0 to MaxNumMergeCand − 2 , inclusive.
VTM, Decoder:
READ_UVLC(uiCode, "max_num_merge_cand_minus_max_num_gpm_cand");
CHECK(pcSPS->getMaxNumMergeCand() < uiCode, "Incorrrect max number of GEO candidates!");
VTM, Encoder:
WRITE_UVLC(pcSPS->getMaxNumMergeCand() - pcSPS->getMaxNumGeoCand(), "max_num_merge_cand_minus_max_num_gpm_cand");
Should be:
VTM, Decoder:
READ_UVLC(uiCode, "max_num_merge_cand_minus_max_num_gpm_cand");
CHECK((pcSPS->getMaxNumMergeCand() - 2) < uiCode, "Incorrrect max number of GEO candidates!");
VTM, Encoder:
WRITE_UVLC(pcSPS->getMaxNumMergeCand() - pcSPS->getMaxNumGeoCand() - 2, "max_num_merge_cand_minus_max_num_gpm_cand");
Change history (2)
comment:1 Changed 4 years ago by fbossen
comment:2 Changed 4 years ago by XiangLi
- Milestone set to VTM-10.0
- Resolution set to fixed
- Status changed from new to closed
Fixed as suggested.
Note: See TracTickets for help on using tickets.
The suggested encoder modification appears incorrect.
Proposed fix for range check:
https://vcgit.hhi.fraunhofer.de/jvet/VVCSoftware_VTM/-/merge_requests/1800