Opened 3 months ago

Closed 2 months ago

#1143 closed defect (fixed)

Wrong check for sh_slice_address when pps_rect_slice_flag is equal to 1

Reported by: hbteo Owned by:
Priority: minor Milestone: VTM-10.0
Component: VTM Version: VTM-9.0
Keywords: Cc: ksuehring, XiangLi, fbossen, jvet@…

Description

Spec description:
Otherwise (pps_rect_slice_flag is equal to 1), the following applies:

  • ...
  • The value of sh_slice_address shall be in the range of 0 to NumSlicesInSubpic[ CurrSubpicIdx ] − 1, inclusive.

VTM implementation:

      int bitsSliceAddress = ceilLog2(currSubPic.getNumSlicesInSubPic());
      READ_CODE(bitsSliceAddress, uiCode, "slice_address");  sliceAddr = uiCode;
      CHECK(sliceAddr >= pps->getNumSlicesInPic(), "Invalid slice address");

It should be checking number of slices in subpic:

      int bitsSliceAddress = ceilLog2(currSubPic.getNumSlicesInSubPic());
      READ_CODE(bitsSliceAddress, uiCode, "slice_address");  sliceAddr = uiCode;
      CHECK(sliceAddr >= currSubPic.getNumSlicesInSubPic(), "Invalid slice address");

Change history (2)

comment:2 Changed 2 months ago by XiangLi

  • Milestone set to VTM-10.0
  • Resolution set to fixed
  • Status changed from new to closed

Fixed as suggested.

Note: See TracTickets for help on using tickets.