Opened 5 years ago

Closed 5 years ago

#115 closed defect (fixed)

Buggy rate estimation in estIntraPredLumaQT

Reported by: keydel Owned by:
Priority: critical Milestone: VTM-3.0
Component: VTM Version: VTM-3.0rc1
Keywords: Cc: ksuehring, XiangLi, fbossen, jvet@…

Description

The rate estimation in estIntraPredLumaQT (Hadamard search) is not correct, since context models for MHIntraModes and MultiRefIdx are being ignored during context reset process.
Bugfix is attached! Please look for macro INTRA_SEARCH_CONTEXT_BUGFIX in IntraSearch.cpp

Attachments (1)

IntraSearch.cpp​ (68.3 KB) - added by keydel 5 years ago.
bugfix example

Download all attachments as: .zip

Change history (4)

Changed 5 years ago by keydel

bugfix example

comment:1 Changed 5 years ago by ksuehring

Can you please submit a merge request to the VTM repository? That will make it much easier to review.

comment:2 Changed 5 years ago by ksuehring

Btw, bug fixes should not be enclosed in macros. These make the code hard to read an usually there is no reason to go back.

comment:3 Changed 5 years ago by XiangLi

  • Resolution set to fixed
  • Status changed from new to closed

Fixed in ​https://vcgit.hhi.fraunhofer.de/jvet/VVCSoftware_VTM/merge_requests/106

Note: See TracTickets for help on using tickets.