Opened 2 years ago

Closed 2 years ago

#128 closed defect (wontfix)

incorrect modulo value used in adjacent mode calculations

Reported by: andrew.dorrell Owned by:
Priority: minor Milestone:
Component: spec Version: VVC D3 v8
Keywords: intra MPM Cc: vzakharc, yuwenhe, jvet@…

Description

In section 8.2.2 and equations ranging from 8-7 through 8-53, adjacent angular modes are calculated for the purpose of populating a most probable mode list.The equations have the general form

new_mode = 2 + ((mode + a) % b)

where b is 64 and a is a function of the distance new_mode should be offset from mode. It could for example be determined as follows:

a = delta + NUM_ANGULAR_MODES - 2     (if delta is negative)
a = delta - 2                         (if delta is positive)

The defect arises because of the modulo b=64. This is a defect because it means that the maximum value that new_mode can take is 63+2=65 (even though 66 is a legitimate and legal value). This may also mean that some values for the offset amount 'a' need to be revised in the text. However this requires a clear statement of the intention of the calculation.

The consequences of this wrt the code are documented in https://jvet.hhi.fraunhofer.de/trac/vvc/ticket/127

Change history (7)

comment:1 Changed 2 years ago by andrew.dorrell

  • Component changed from 360Lib to spec

comment:2 Changed 2 years ago by andrew.dorrell

  • Keywords intra MPM added

comment:3 Changed 2 years ago by bbross

  • Version changed from VVC D3 v3 to VVC D3 v6

comment:4 Changed 2 years ago by bbross

  • Version changed from VVC D3 v6 to VVC D3 v7

comment:5 Changed 2 years ago by bbross

Is there a mismatch between VTM and spec?
If not this seems like a normative change that would need to be discussed at the next meeting.

comment:6 Changed 2 years ago by bbross

  • Version changed from VVC D3 v7 to VVC D3 v8

comment:7 Changed 2 years ago by bbross

  • Resolution set to wontfix
  • Status changed from new to closed

mod 64 was a design choice and thus VTM and draft text reflect the intended design.

Note: See TracTickets for help on using tickets.