Opened 4 years ago
Closed 4 years ago
#1394 closed defect (fixed)
NALread.cpp convertPayloadToRBSP not called correctly
Reported by: | karlsharman | Owned by: | |
---|---|---|---|
Priority: | minor | Milestone: | VTM-11.2 |
Component: | VTM | Version: | |
Keywords: | Cc: | ksuehring, XiangLi, fbossen, jvet@… |
Description
NALread.cpp function convertPayloadToRBSP is not called correctly from read().
The parameter "isVclNalUnit" is set true if bit 6 of nalUnitBuf[0] is 0.
In HEVC, this correlated with nal_unit_type, bit 5, which was 0 for all VCL NUTs (and 1 for all non-VCL).
In VVC, this currently corresponds with bit 4 of nuh_layer_id.
It probably should instead be based upon (nalUnitBuf[1]&31)<12.
The impact is to remove trailing 0s from non-VCL NAL units, prior to interpretation, which may not be desired.
Change history (2)
comment:1 Changed 4 years ago by fbossen
comment:2 Changed 4 years ago by fbossen
- Milestone set to VTM-11.2
- Resolution set to fixed
- Status changed from new to closed
Note: See TracTickets for help on using tickets.
Suggested fix:
https://vcgit.hhi.fraunhofer.de/jvet/VVCSoftware_VTM/-/merge_requests/1981