Opened 3 years ago

Closed 3 years ago

#1480 closed defect (fixed)

Wrong order of coding initial_cpb_removal_delay and initial_cpb_removal_delay_offset

Reported by: hbteo Owned by:
Priority: minor Milestone: VTM-12.2
Component: VTM Version: VTM-12.0
Keywords: Cc: ksuehring, XiangLi, fbossen, jvet@…

Description

In SEIReader::xParseSEIBufferingPeriod, order is [i][j]

sei.m_initialCpbRemovalDelay[i][j][nalOrVcl] = code;
sei.m_initialCpbRemovalOffset[i][j][nalOrVcl] = code;

But in SEIWriter::xWriteSEIBufferingPeriod, order is [j][i]

WRITE_CODE( sei.m_initialCpbRemovalDelay[j][i][nalOrVcl],  sei.m_initialCpbRemovalDelayLength,           "initial_cpb_removal_delay[j][i][nalOrVcl]" );
WRITE_CODE( sei.m_initialCpbRemovalOffset[j][i][nalOrVcl], sei.m_initialCpbRemovalDelayLength,           "initial_cpb_removal_delay_offset[j][i][nalOrVcl]" );

Suggest to change SEIWriter part to [i][j].
MR!2044 has been submitted to fix this problem.

Change history (2)

comment:1 Changed 3 years ago by hbteo

Additionally, in SEIEncoder::initSEIBufferingPeriod, order is [j][i]

bufferingPeriodSEI->m_initialCpbRemovalDelay[j][i][0] = uiInitialCpbRemovalDelay;
bufferingPeriodSEI->m_initialCpbRemovalDelay[j][i][1] = uiInitialCpbRemovalDelay;
bufferingPeriodSEI->m_initialCpbRemovalOffset[j][i][0] = uiInitialCpbRemovalDelay;
bufferingPeriodSEI->m_initialCpbRemovalOffset[j][i][1] = uiInitialCpbRemovalDelay;

This should also be changed to [i][j].
MR!2044 has been updated to include this fix.

All the changes described will align VTM to the specification text.

comment:2 Changed 3 years ago by fbossen

  • Milestone set to VTM-12.2
  • Resolution set to fixed
  • Status changed from new to closed
Note: See TracTickets for help on using tickets.