Opened 3 years ago
Closed 2 years ago
#1551 closed defect (fixed)
missing conformance check on TransCoeffLevel for dependent quantization
Reported by: | iole_moccagatta | Owned by: | |
---|---|---|---|
Priority: | minor | Milestone: | VTM-16.1 |
Component: | VTM | Version: | VTM-16.0 |
Keywords: | Cc: | ksuehring, fbossen, XiangLi, jvet@… |
Description
VTM is missing conformance check on TransCoeffLevel for dependent quantization.
This setting of TransCoeffLevel in the spec residual coding syntax for dependent quantization (sh_dep_quant_used_flag = 1):
TransCoeffLevel[ x0 ][ y0 ][ cIdx ][ xC ][ yC ] = ( 2 * AbsLevel[ xC ][ yC ] − ( QState > 1 ? 1 : 0 ) ) * ( 1 − 2 * coeff_sign_flag[ n ] )
is implemented in line 777 of DepQuant.cpp:
Intermediate_Int qIdx = 2 * level + (level > 0 ? -(state >> 1) : (state >> 1));
TransCoeffLevel must be in the range of CoeffMin to CoeffMax, inclusive.
So, a check on qIdx should be added after line 777 to catch non conformance bitstreams.
Change history (1)
comment:1 Changed 2 years ago by ksuehring
- Milestone set to VTM-16.1
- Resolution set to fixed
- Status changed from new to closed
Note: See TracTickets for help on using tickets.
Fixed in
https://vcgit.hhi.fraunhofer.de/jvet/VVCSoftware_VTM/-/merge_requests/2241