Opened 15 months ago

Closed 6 months ago

#1573 closed defect (fixed)

Memory leaks detected in VTM decoder

Reported by: marie-pierre.gallasso Owned by:
Priority: major Milestone: VTM-20.0
Component: VTM Version: VTM-19.0
Keywords: Cc: ksuehring, XiangLi, fbossen, jvet@…


The vtm decoder software 18.0 (commit 3711eda2cff4777b28b3338d6bc4783424fc6d30) contains memory leaks. You can reproduce the problem by decoding a stream with asan.

==5050==ERROR: LeakSanitizer: detected memory leaks
Direct leak of 20544 byte(s) in 4 object(s) allocated from:
    #0 0x55bb2ab2ef8d in operator new(unsigned long) 
    #1 0x55bb2af738b2 in Picture::finalInit(VPS const*, SPS const&, PPS const&, PicHeader*, APS**, APS*, APS*) source/Lib/CommonLib/Picture.cpp:272:19
    #2 0x55bb2abb36d1 in DecLib::xActivateParameterSets(InputNALUnit) source/Lib/DecoderLib/DecLib.cpp:1993:14
    #3 0x55bb2abd2878 in DecLib::xDecodeSlice(InputNALUnit&, int&, int) source/Lib/DecoderLib/DecLib.cpp:3033:3
    #4 0x55bb2ab9199b in DecLib::decode(InputNALUnit&, int&, int&, int) source/Lib/DecoderLib/DecLib.cpp:3704:41
    #5 0x55bb2ab38f06 in DecApp::decode() source/App/DecoderApp/DecApp.cpp:281:21
    #6 0x55bb2ab31e60 in main source/App/DecoderApp/decmain.cpp:93:24
    #7 0x7f3936345d09 in __libc_start_main csu/../csu/libc-start.c:308:16

Attachments (1)

memory_leaks.vvc (21.5 KB) - added by marie-pierre.gallasso 14 months ago.

Download all attachments as: .zip

Change history (10)

Changed 14 months ago by marie-pierre.gallasso

comment:1 Changed 14 months ago by marie-pierre.gallasso

I still find memory leaks in VTM software commit 72c11672096e17e83cb166f4705ae06ebf90b1b5, when decoding some streams.
Please check with the stream in attachment

comment:2 Changed 12 months ago by marie-pierre.gallasso

  • Version set to VTM-18.2

comment:3 Changed 11 months ago by marie-pierre.gallasso

  • Version changed from VTM-18.2 to VTM-19.0

still finding memory leaks with VTM 19.0 !

comment:4 Changed 11 months ago by fbossen

Yes, there are still leaks related to picture header management. No fix has been submitted so far.

comment:5 Changed 11 months ago by marie-pierre.gallasso

The memory leaks have been introduced by commit d098aef653e3806016fad301c1d76706d3303f57

comment:6 Changed 11 months ago by ksuehring

comment:7 Changed 11 months ago by ksuehring

The fix above unfortunately broke the encoder. There is a new MR available with a larger refactoring, which should hopefully fix the issue without breaking anything else.

It would be good, if people who are familiar with GDR could test this to make sure GDR still works as expected.

comment:8 Changed 11 months ago by marie-pierre.gallasso

That's fine, your MR corrects the memory leaks. Thanks.

comment:9 Changed 6 months ago by XiangLi

  • Milestone set to VTM-20.0
  • Resolution set to fixed
  • Status changed from new to closed

Fixed in !2501.

Note: See TracTickets for help on using tickets.