Memory leaks detected in VTM decoder

[marie-pierre.gallasso]

The vtm decoder software 18.0 (commit 3711eda2cff4777b28b3338d6bc4783424fc6d30) contains memory leaks. You can reproduce the problem by decoding a stream with asan.

==5050==ERROR: LeakSanitizer: detected memory leaks
Direct leak of 20544 byte(s) in 4 object(s) allocated from:
    #0 0x55bb2ab2ef8d in operator new(unsigned long) 
    #1 0x55bb2af738b2 in Picture::finalInit(VPS const*, SPS const&, PPS const&, PicHeader*, APS**, APS*, APS*) source/Lib/CommonLib/Picture.cpp:272:19
    #2 0x55bb2abb36d1 in DecLib::xActivateParameterSets(InputNALUnit) source/Lib/DecoderLib/DecLib.cpp:1993:14
    #3 0x55bb2abd2878 in DecLib::xDecodeSlice(InputNALUnit&, int&, int) source/Lib/DecoderLib/DecLib.cpp:3033:3
    #4 0x55bb2ab9199b in DecLib::decode(InputNALUnit&, int&, int&, int) source/Lib/DecoderLib/DecLib.cpp:3704:41
    #5 0x55bb2ab38f06 in DecApp::decode() source/App/DecoderApp/DecApp.cpp:281:21
    #6 0x55bb2ab31e60 in main source/App/DecoderApp/decmain.cpp:93:24
    #7 0x7f3936345d09 in __libc_start_main csu/../csu/libc-start.c:308:16

[marie-pierre.gallasso]

I still find memory leaks in VTM software commit 72c11672096e17e83cb166f4705ae06ebf90b1b5, when decoding some streams.
Please check with the stream in attachment

[marie-pierre.gallasso]

still finding memory leaks with VTM 19.0 !

[fbossen]

Yes, there are still leaks related to picture header management. No fix has been submitted so far.

[marie-pierre.gallasso]

The memory leaks have been introduced by commit d098aef653e3806016fad301c1d76706d3303f57

[ksuehring]

Please check

​https://vcgit.hhi.fraunhofer.de/jvet/VVCSoftware_VTM/-/merge_requests/2497

This should hopefully fix the leak.

[ksuehring]

The fix above unfortunately broke the encoder. There is a new MR available with a larger refactoring, which should hopefully fix the issue without breaking anything else.

​https://vcgit.hhi.fraunhofer.de/jvet/VVCSoftware_VTM/-/merge_requests/2501

It would be good, if people who are familiar with GDR could test this to make sure GDR still works as expected.

[marie-pierre.gallasso]

That's fine, your MR corrects the memory leaks. Thanks.

[XiangLi]

Fixed in !2501.