#1583 closed defect (fixed)

VTM-19.0 not compiling when the macro REUSE_CU_RESULTS is equal to 0.

Reported by: dumas Owned by:
Priority: minor Milestone: VTM-19.1
Component: VTM Version: VTM-19.0
Keywords: Cc: ksuehring, XiangLi, fbossen, jvet@…

Description

When VTM-19.0 is compiled with REUSE_CU_RESULTS at 0, several compilation errors appear.

ERROR LOG


if ((cuECtx.get<double>(BEST_NO_IMV_COST) == (MAX_DOUBLE * .5)
cuECtx.get<bool>(IS_REUSING_CU)) && !slice.isIntra())


[ 76%] Building CXX object source/Lib/DecoderAnalyserLib/CMakeFiles/DecoderAnalyserLib.dir//DecoderLib/DecSlice.cpp.o
make[2]: * [source/Lib/EncoderLib/CMakeFiles/EncoderLib.dir/EncModeCtrl.cpp.o] Error 1
make[2]:
* Waiting for unfinished jobs....
[ 77%] Building CXX object source/Lib/DecoderAnalyserLib/CMakeFiles/DecoderAnalyserLib.dir/
/DecoderLib/NALread.cpp.o
[ 77%] Building CXX object source/Lib/DecoderAnalyserLib/CMakeFiles/DecoderAnalyserLib.dir//DecoderLib/SEIread.cpp.o
[ 78%] Building CXX object source/Lib/DecoderAnalyserLib/CMakeFiles/DecoderAnalyserLib.dir/
/DecoderLib/VLCReader.cpp.o
make[1]: * [source/Lib/EncoderLib/CMakeFiles/EncoderLib.dir/all] Error 2
make[1]:
* Waiting for unfinished jobs....
[ 79%] Linking CXX static library ../../../../lib/umake/gcc-8.3/x86_64/release/libDecoderLib.a
[ 79%] Built target DecoderLib
[ 79%] Linking CXX static library ../../../../lib/umake/gcc-8.3/x86_64/release/libDecoderAnalyserLib.a
[ 79%] Built target DecoderAnalyserLib
make: * [all] Error 2

COMPILATION ENVIRONMENT


OS : CentOS Linux 7 Cores
Compiler : GCC 8.3.1

OTHER TEST


The same error appears when compiling using Windows 11 and MSVC 16-19.29.

POTENTIAL FIX


In "EncModeCtlr.cpp", line 1874, "
cuECtx.get<bool>(IS_REUSING_CU)" can be wrapped by the macro REUSE_CU_RESULTS.
  1. In "EncCfg.h", line 1580, the following code

#if REUSE_CU_RESULTS

ChromaFormat getChromaFormatIdc ( ) const { return m_chromaFormatIDC; }

#else

ChromaFormat getChromaFormatIdc ( ) { return m_chromaFormatIDC; }

#endif

can become

ChromaFormat getChromaFormatIdc ( ) const { return m_chromaFormatIDC; }

With 1. and 2., the compilation completes.

Change history (2)

comment:1 Changed 18 months ago by XiangLi

Thanks for the report. I think this issue has been fixed in https://vcgit.hhi.fraunhofer.de/jvet/VVCSoftware_VTM/-/merge_requests/2424. Please give the master tip a try.

comment:2 Changed 18 months ago by XiangLi

  • Milestone changed from VTM-19.0 to VTM-19.1
  • Resolution set to fixed
  • Status changed from new to closed
Note: See TracTickets for help on using tickets.