Opened 18 months ago
Closed 18 months ago
#1597 closed defect (fixed)
Incorrect parsing of nnpfc_constant_patch_size_flag
Reported by: | hallapur | Owned by: | |
---|---|---|---|
Priority: | minor | Milestone: | VTM-21.0 |
Component: | VTM | Version: | VTM-20.0 |
Keywords: | SEI parsing | Cc: | ksuehring, XiangLi, fbossen, jvet@… |
Description
The flag is parsed incorrectly which causes decoder crash.
if (sei.m_constantPatchSizeFlag)
{
sei_read_flag(pDecodedMessageOutputStream, val, "nnpfc_constant_patch_size_flag");
sei.m_constantPatchSizeFlag = val;
}
else
Correct way to parse is as follows:
sei_read_flag(pDecodedMessageOutputStream, val, "nnpfc_constant_patch_size_flag");
sei.m_constantPatchSizeFlag = val;
if (sei.m_constantPatchSizeFlag)
{
sei_read_uvlc(pDecodedMessageOutputStream, val, "nnpfc_patch_width_minus1");
sei.m_patchWidthMinus1 = val;
sei_read_uvlc(pDecodedMessageOutputStream, val, "nnpfc_patch_height_minus1");
sei.m_patchHeightMinus1 = val;
}
else
Change history (3)
comment:1 Changed 18 months ago by hallapur
comment:2 Changed 18 months ago by hallapur
Proposed fix in this merge request:
https://vcgit.hhi.fraunhofer.de/jvet/VVCSoftware_VTM/-/merge_requests/2586
comment:3 Changed 18 months ago by XiangLi
- Milestone set to VTM-21.0
- Resolution set to fixed
- Status changed from new to closed
The suggested fix has been merged.
Also, nnpfc_overlap is parsed twice, before and after nnpfc_constant_patch_size_flag parsing.