Opened 8 months ago

Closed 6 months ago

#1621 closed defect (fixed)

Compilation issue in non-X86 environments

Reported by: jani.lainema Owned by:
Priority: minor Milestone:
Component: VTM Version:
Keywords: Cc: ksuehring, XiangLi, fbossen, jvet@…

Description

SIMD implementation of transforms (merge request !2695) seems to break compilation at least in some non-X86 environments. For example, compilation fails with long list of errors when using cmake 3.27.7, clang compiler 15.0.0.15000040 and default settings of XCode 15.0.1 in MacOS.

Reason for the failure appears to be that the new TrQuantX86.h #includes an x86 SIMD header file even if the target architecture is not supporting such. Encapsulating the contents of that file inside "#ifdef TARGET_SIMD_X86" seems to fix the issue.

Interestingly the VTM git's MacOS pipeline tests don't capture this problem. Wonder if one of those can be configured so that this kind of errors would be identified automatically?

Change history (3)

comment:1 Changed 8 months ago by jani.lainema

In addition to the modification proposed in the original ticket, it seems we also need to move

#include "../CommonDef.h"

above the #ifdef TARGET_SIMD_X86 to get that macro properly defined in the context of this file.

comment:2 Changed 8 months ago by ksuehring

Thanks for the report. The MacOS build server is still x86. I'm going to add an M2 Mac to the pipelines, so that we will be able to identify this kind of bugs more easily in the future.

comment:3 Changed 6 months ago by fbossen

  • Resolution set to fixed
  • Status changed from new to closed

An ARM build has been added to the test pipeline:
https://vcgit.hhi.fraunhofer.de/jvet/VVCSoftware_VTM/-/merge_requests/2718

Note: See TracTickets for help on using tickets.