Opened 5 years ago

Closed 5 years ago

#296 closed defect (fixed)

a bug in MCTS code

Reported by: luoda Owned by:
Priority: major Milestone: VTM-5.1
Component: VTM Version: VTM-5.0
Keywords: Cc: ksuehring, XiangLi, fbossen, jvet@…

Description

In void InterSearch::xAffineMotionEstimation(). The brackets are missing in the else statement.

  // do motion compensation with origin mv
  if( m_pcEncCfg->getMCTSEncConstraint() )
  {
    Area curTileAreaRestricted = pu.cs->picture->mctsInfo.getTileAreaSubPelRestricted( pu );
    MCTSHelper::clipMvToArea( acMvTemp[0], pu.cu->Y(), curTileAreaRestricted, *pu.cs->sps );
    MCTSHelper::clipMvToArea( acMvTemp[1], pu.cu->Y(), curTileAreaRestricted, *pu.cs->sps );
    if( pu.cu->affineType == AFFINEMODEL_6PARAM )
    {
      MCTSHelper::clipMvToArea( acMvTemp[2], pu.cu->Y(), curTileAreaRestricted, *pu.cs->sps );
    }
  }
  else
  clipMv( acMvTemp[0], pu.cu->lumaPos(),
          pu.cu->lumaSize(),
          *pu.cs->sps );
  clipMv( acMvTemp[1], pu.cu->lumaPos(),
          pu.cu->lumaSize(),
          *pu.cs->sps );
  if ( pu.cu->affineType == AFFINEMODEL_6PARAM )
  {
    clipMv( acMvTemp[2], pu.cu->lumaPos(),
            pu.cu->lumaSize(),
            *pu.cs->sps );
  }

should be:

  // do motion compensation with origin mv
  if( m_pcEncCfg->getMCTSEncConstraint() )
  {
    Area curTileAreaRestricted = pu.cs->picture->mctsInfo.getTileAreaSubPelRestricted( pu );
    MCTSHelper::clipMvToArea( acMvTemp[0], pu.cu->Y(), curTileAreaRestricted, *pu.cs->sps );
    MCTSHelper::clipMvToArea( acMvTemp[1], pu.cu->Y(), curTileAreaRestricted, *pu.cs->sps );
    if( pu.cu->affineType == AFFINEMODEL_6PARAM )
    {
      MCTSHelper::clipMvToArea( acMvTemp[2], pu.cu->Y(), curTileAreaRestricted, *pu.cs->sps );
    }
  }
  else
  {
  clipMv( acMvTemp[0], pu.cu->lumaPos(),
          pu.cu->lumaSize(),
          *pu.cs->sps );
  clipMv( acMvTemp[1], pu.cu->lumaPos(),
          pu.cu->lumaSize(),
          *pu.cs->sps );
  if ( pu.cu->affineType == AFFINEMODEL_6PARAM )
  {
    clipMv( acMvTemp[2], pu.cu->lumaPos(),
            pu.cu->lumaSize(),
            *pu.cs->sps );
  }
  }

Change history (2)

comment:1 Changed 5 years ago by ksuehring

MR 609 was submitted to address this issue

​https://vcgit.hhi.fraunhofer.de/jvet/VVCSoftware_VTM/merge_requests/609

comment:2 Changed 5 years ago by ksuehring

  • Milestone set to VTM-5.1
  • Resolution set to fixed
  • Status changed from new to closed

The MR was merged

Note: See TracTickets for help on using tickets.