Opened 3 years ago

Closed 3 years ago

#30 closed defect (fixed)

Use of uninitialized Cabac coder for Intra 128x128 blocks

Reported by: tpoirier Owned by:
Priority: minor Milestone: HM-16.6-JEM-3.2
Component: JEM Version: HM-16.6-JEM-3.1
Keywords: Cc: ksuehring, XiangLi, jvet@…

Description

In xCheckRDCostIntra, for block greater than 4096 pixels, an early termination avoid doing RDO on the current block, but xCheckBestMode() copy the current Cabac coder which is uninitialized. This uninitialized coder is then used for estimating the cost of coding the split flag.
The following 2 patches should solve the problem without changing performance.
The quick patch is straightforward, but I personally suggest the second one that remove unnecessary copies of Cabac coders.

Tangi

Attachments (2)

quick_fix.patch (1.0 KB) - added by tpoirier 3 years ago.
rm_useless_ctx_copy.patch (3.9 KB) - added by tpoirier 3 years ago.

Download all attachments as: .zip

Change history (3)

Changed 3 years ago by tpoirier

Changed 3 years ago by tpoirier

comment:1 Changed 3 years ago by XiangLi

  • Milestone set to HM-16.6-JEM-3.2
  • Resolution set to fixed
  • Status changed from new to closed

Fixed in r295

Note: See TracTickets for help on using tickets.