Opened 5 years ago

Closed 5 years ago

#34 closed defect (fixed)

intra-fast encoder-side decisions based on possibly incorrect obmc pred buffer

Reported by: gordon Owned by:
Priority: minor Milestone:
Component: JEM Version: HM-16.6-JEM-3.2
Keywords: obmc, intra-fast, encoder-side decisions Cc: ksuehring, XiangLi, jvet@…

Description

Present in jem4.0 rc1.
In TEncCu::xCheckRDCostInter obmc is tried 'on', then 'off'. When it's tried 'off' it uses a different prediction buffer that is not saved in rpcTempCU. If this becomes the winning candidate after xCheckBestMode, this "wrong" prediction buffer is used in a later JVET_C0024_PBINTRA_FAST test in xCompressCU.

The attached patch seems to correct the problem, but needs to be verified.
Compression gain differences on 17-frame RA tests we've done show very small average differences, but with variations up to +/- 0.3%

Attachments (1)

obmcfix-patch.patch (1.6 KB) - added by gordon 5 years ago.

Download all attachments as: .zip

Change history (2)

Changed 5 years ago by gordon

comment:1 Changed 5 years ago by XiangLi

  • Resolution set to fixed
  • Status changed from new to closed

Fixed in r324.

Note: See TracTickets for help on using tickets.