Opened 5 years ago

Closed 3 years ago

#342 closed defect (invalid)

CTU boundary position not computed correctly for Chroma deblocking

Reported by: AnandMeher Owned by:
Priority: minor Milestone:
Component: VTM Version: VTM-5.0
Keywords: Longer tap deblocking for Chroma Cc: ksuehring, XiangLi, fbossen, jvet@…

Description

For the Chroma longer tap deblocking, longer tap filter is currently switched off at the horizontal CTU boundaries to reduce line buffer.

In the VTM-5.0 code, in function xEdgeFilterChroma, the position for the horizontal CTU boundary seems to be computed incorrectly, which is as follows:
pos.y % cuP.slice->getSPS()->getCTUSize() == 0
which does not take into account the Chroma re-scaling based on the Chroma format.

A possible fix could be as follows:
(pos.y % (cuP.slice->getSPS()->getCTUSize() >> ::getComponentScaleX(COMPONENT_Cb, nChromaFormat)) == 0)

Change history (2)

comment:1 Changed 5 years ago by AnandMeher

After further investigation, it seems the implementation of VTM-5.0 is correct as "pos.y" variable is already re-scaled. Therefore this ticket can be closed.

comment:2 Changed 3 years ago by fbossen

  • Resolution set to invalid
  • Status changed from new to closed
Note: See TracTickets for help on using tickets.