Opened 2 years ago

Closed 2 years ago

#372 closed defect (fixed)

Updating firstNZPos for sign data hiding

Reported by: bheng Owned by:
Priority: minor Milestone: VTM-6.0
Component: VTM Version: VTM-5.2
Keywords: Cc: ksuehring, XiangLi, fbossen, jvet@…

Description

In CABACReader.cpp and CABACWriter.cpp, residual_coding_subblock( ) functions, it appears that the firstNZPos for determining the sign data hiding threshold needs to be updated in the final "coeff bypass" loop.

Something like the highlighted line below.

if( tcoeff )
{

int blkPos = cctx.blockPos( scanPos );
sigBlkPos[ numNonZero++ ] = blkPos;
firstNZPos = scanPos;
lastNZPos = std::max<int>( lastNZPos, scanPos );
coeff[blkPos] = tcoeff;

}

Change history (2)

comment:1 Changed 2 years ago by bheng

Merge request 755 from Spec Ticket #400 would fix this.

https://vcgit.hhi.fraunhofer.de/jvet/VVCSoftware_VTM/merge_requests/755

comment:2 Changed 2 years ago by XiangLi

  • Milestone set to VTM-6.0
  • Resolution set to fixed
  • Status changed from new to closed
Note: See TracTickets for help on using tickets.