Opened 5 years ago
Closed 3 years ago
#505 closed defect (fixed)
Missing context initialization for TsResidualSign in BDPCM mode
Reported by: | auyeung | Owned by: | |
---|---|---|---|
Priority: | minor | Milestone: | |
Component: | VTM | Version: | VTM-6.0 |
Keywords: | Cc: | ksuehring, XiangLi, fbossen, jvet@… |
Description
In VTM6.0, we have
const CtxSet ContextSetCfg::TsResidualSign = ContextSetCfg::addCtxSet ({ { 28, 25, 53, CNU, CNU, CNU, }, { 5, 10, 53, CNU, CNU, CNU, }, { 20, 2, 46, CNU, CNU, CNU, }, { 1, 4, 4, DWS, DWS, DWS, }, });
The context initialization values for BDPCM mode is missing. It might be caused by not using classF.cfg for Class F and Class TGM test sequences in the retraining process.
Suggested value based on JVET-N-CE1 retraining method:
const CtxSet ContextSetCfg::TsResidualSign = ContextSetCfg::addCtxSet ({ { 28, 25, 53, 35, 26, 30, }, { 5, 10, 53, 35, 33, 38, }, { 20, 2, 46, 28, 33, 38, }, { 1, 4, 4, 5, 5, 8, }, });
Change history (3)
comment:1 Changed 5 years ago by fbossen
comment:2 Changed 4 years ago by ksuehring
- Milestone VTM-6.2 deleted
comment:3 Changed 3 years ago by fbossen
- Resolution set to fixed
- Status changed from new to closed
Note: See TracTickets for help on using tickets.
The reason init values show as "CNU" is that the class F config file was broken in VTM 6.0rc1, which is the version that was used for training.
The class F config file was broken here:
https://vcgit.hhi.fraunhofer.de/jvet/VVCSoftware_VTM/merge_requests/731/
and fixed here:
https://vcgit.hhi.fraunhofer.de/jvet/VVCSoftware_VTM/merge_requests/858/
I expect other syntax elements might affected by this. Unless you have data showing this has a significant impact, I wouldn't bother fixing this until the next training round (VTM 7.0).