Opened 3 years ago

Closed 3 years ago

#57 closed defect (fixed)

Inconsistent comparison of invalid motion vectors

Reported by: adamjw Owned by:
Priority: minor Milestone: HM-16.6-JEM-7.2
Component: JEM Version: HM-16.6-JEM-7.1
Keywords: TComMv Cc: ksuehring, XiangLi, jvet@…

Description

When comparing motion vectors in TComMotionInfo:

return ( m_acMv.getHor() == rcMv.getHor() && m_acMv.getVer() == rcMv.getVer() && m_iRefIdx == rcMv.getRefIdx() );

if the motion vector is invalid (e.g. refernce index is set to NOT_VALID), the vector components are still evaluated. That way, two invalid motion vectors, when compared, might be equal or unequal, depending on invalid (possibly uninitialized) vector component data.

Please find the attached fix.

Attachments (1)

invalid_mv_comparison.patch (1.2 KB) - added by adamjw 3 years ago.
bugfix for inconsistent motion vector comparison

Download all attachments as: .zip

Change history (2)

Changed 3 years ago by adamjw

bugfix for inconsistent motion vector comparison

comment:1 Changed 3 years ago by XiangLi

  • Milestone changed from HM-16.6-JEM-7.1 to HM-16.6-JEM-7.2
  • Resolution set to fixed
  • Status changed from new to closed
  • Version changed from HM-16.6-JEM-7.0 to HM-16.6-JEM-7.1

Thanks for the report. The issue has been fixed as in r597.

Note: See TracTickets for help on using tickets.