Opened 6 years ago

Closed 6 years ago

#77 closed defect (fixed)

Accessing uninitialized memory in intra prediction PDPC/WAIP

Reported by: ksuehring Owned by:
Priority: minor Milestone: BMS-2.0.1
Component: BMS Version: BMS-2.0
Keywords: Intra, PDPC, WAIP Cc: ksuehring, XiangLi, fbossen, jvet@…

Description (last modified by ksuehring)

I got a bug report privately about valgrind reporting the decoder to access uninitialized/not existing memory.

Location: IntraPrediction.cpp line 1039

          int c = x + y + 1;
          const Pel left = refSide[c + 1];
          const Pel top = refMain[c + 1];

          pDsty[x] = ClipPel((wL * left + wT * top + (64 - wL - wT) * pDsty[x] + 32) >> 6, clpRng);

left seems to point to an unavailable location at some point.

Test setup:

1 frame BQSquare encoded with VTM config QP=32 on Linux/gcc 7.2.1, decoder running with valgrind.

My be an interaction between JVET_K0063_PDPC_SIMP and JVET_K0500_WAIP implementations.

Change history (3)

comment:1 Changed 6 years ago by ksuehring

  • Description modified (diff)

comment:2 Changed 6 years ago by ksuehring

  • Milestone set to BMS-2.0.1

Fixed in BMS-2.0.1, see merge request !72

​​https://vcgit.hhi.fraunhofer.de/jvet/VVCSoftware_BMS/merge_requests/72

comment:3 Changed 6 years ago by ksuehring

  • Resolution set to fixed
  • Status changed from new to closed
Note: See TracTickets for help on using tickets.