Opened 5 years ago
Closed 5 years ago
#849 closed defect (fixed)
Geo Prediction Mode - Mismatch between text and SW
Reported by: | bheng | Owned by: | |
---|---|---|---|
Priority: | minor | Milestone: | |
Component: | spec | Version: | VVC D8 vB |
Keywords: | Cc: | ksuehring, bbross, XiangLi, fbossen, jvet@… |
Description
The text and software appear to use opposite definitions of the "isFlip" flag during Geo parameter dervation for motion vector storage:
Text:
partIdx = ( angleIdx >= 13 && angleIdx <= 27 ) ? 0 : 1 (1052)
SW:
bool isFlip = angle >= 13 && angle <= 27;
However, the usage of this flag is the same:
Text:
sType = abs( motionIdx ) < 32 ? 2 : ( motionIdx <= 0 ? ( 1 - partIdx ) : partIdx ) (1059)
SW:
tpmMask = abs(motionIdx) < 32 ? 2 : (motionIdx <= 0 ? (1 - isFlip) : isFlip);
The SW seems to be consistent with the weights applied, so I guess the text needs to be fixed in some way (either redefine flip or swap the usage).
Also, as of JVET-Q2001-vB, there are issues with parenthesis in equations 1053 and 1058.
Change history (1)
comment:1 Changed 5 years ago by bbross
- Resolution set to fixed
- Status changed from new to closed
Good catch, thanks!
This will be fixed in first version of D10.