Mismatch between spec and software on length of slice_subpic_id

[vdrugeon]

VVC D8 states: "The length of slice_subpic_id is sps_subpic_id_len_minus1 + 1 bits." This is independent from the value of subpic_id_mapping_explicitly_signalled_flag or subpic_id_mapping_in_pps_flag.

However, the following code can be found in HLSyntaxReader::parseSliceHeader:

#if JVET_Q0119_CLEANUPS
  if (sps->getSubPicInfoPresentFlag())
#else
  if (sps->getSubPicPresentFlag())
#endif
  {
    uint32_t bitsSubPicId;
#if JVET_Q0119_CLEANUPS
    if (sps->getSubPicIdMappingExplicitlySignalledFlag())
#else
    if (sps->getSubPicIdSignallingPresentFlag())
#endif
    {
      bitsSubPicId = sps->getSubPicIdLen();
    }
#if !JVET_Q0119_CLEANUPS
    else if (picHeader->getSubPicIdSignallingPresentFlag())
    {
      bitsSubPicId = picHeader->getSubPicIdLen();
    }
#endif
#if JVET_Q0119_CLEANUPS
    else if (pps->getSubPicIdMappingInPpsFlag())
#else
    else if (pps->getSubPicIdSignallingPresentFlag())
#endif
    {
      bitsSubPicId = pps->getSubPicIdLen();
    }
    else
    {
      bitsSubPicId = ceilLog2(sps->getNumSubPics());
    }
    READ_CODE(bitsSubPicId, uiCode, "slice_subpic_id");    pcSlice->setSliceSubPicId(uiCode);
  }

[vdrugeon]

Could experts please have a look at the following merge request to confirm if it is solving the issue?
​https://vcgit.hhi.fraunhofer.de/jvet/VVCSoftware_VTM/merge_requests/1429

[KuiFan]

Replying to vdrugeon:

Could experts please have a look at the following merge request to confirm if it is solving the issue?
​https://vcgit.hhi.fraunhofer.de/jvet/VVCSoftware_VTM/merge_requests/1429

Hi Virginie,

Thanks for the fix. I think it solves this issue.

[XiangLi]

Fixed as suggested in MR 1429