VTM-8.0 master (6f1b5b6) decoder exits in non-CTC configuration

[tung.nguyen]

-c .\cfg\encoder_randomaccess_vtm.cfg -c .\cfg\per-sequence\BQSquare.cfg -q 32 -i BQSquare_416x240_60.yuv --IntraPeriod=-1

Decoder crashes at the 7th picture (POC 1) in the parsing process, message is either "DecSlice.cpp:248: Expecting a terminating bit" or "BitStream.h:174: FIFO exceeded".

[ksuehring]

I was running 33 frames in my test. I got a mismatch earlier:

Encoder log:

POC    0 LId:  0 TId: 0 ( I-SLICE, QP 34 )      51304 bits [Y 34.1090 dB    U 37.3275 dB    V 37.8976 dB] [ET    32 ] [L0] [L1] [MD5:e57aba9113e529ce7f12a35531efca44,118164c5209ace4f089efa9c9ce393d9,03d18ca16778aaa46aa59434de419079]
POC   16 LId:  0 TId: 0 ( B-SLICE, QP 34 )      38288 bits [Y 34.1556 dB    U 37.4144 dB    V 37.2097 dB] [ET    63 ] [L0 0] [L1 0c] [MD5:cddad13c709dfdad859176eba59ae4fc,e18c8d78974b2fe86abdf770d1ce3dec,78c9c55acb6c0908b9e6e540b1394578]
POC    8 LId:  0 TId: 1 ( B-SLICE, QP 34 )      27048 bits [Y 33.3453 dB    U 36.8791 dB    V 37.0280 dB] [ET    59 ] [L0 0 16] [L1 16c 0] [MD5:fa5776a1df54e92b8547eca1b00c42f6,f555afff0c4ef6d9b7eed7741a674c75,183fb08656621a86459ea2b7b8204e6c]
POC    4 LId:  0 TId: 2 ( B-SLICE, QP 34 )      19064 bits [Y 33.3682 dB    U 37.1637 dB    V 37.4730 dB] [ET    50 ] [L0 0 8] [L1 8c 16] [MD5:5da85ebe62f3bb2fafc3af5896b6f7a0,52544903e297e4557a65e574e686ad76,1f9e1f5a95bd9d578a4c96ec46474038]

Decoder log:

POC    0 LId:  0 TId: 0 ( I-SLICE, QP 34 ) [DT  0.030] [L0] [L1] [MD5:e57aba9113e529ce7f12a35531efca44,118164c5209ace4f089efa9c9ce393d9,03d18ca16778aaa46aa59434de419079,(OK)] 
POC   16 LId:  0 TId: 0 ( B-SLICE, QP 34 ) [DT  0.023] [L0 0] [L1 0c] [MD5:cddad13c709dfdad859176eba59ae4fc,e18c8d78974b2fe86abdf770d1ce3dec,78c9c55acb6c0908b9e6e540b1394578,(OK)] 
POC    8 LId:  0 TId: 1 ( B-SLICE, QP 34 ) [DT  0.017] [L0 0 16] [L1 0c 16] [MD5:0b6c6abfca49b0c2e79acdaf7d08c0ed,3af754d01eb163781269ac9fcf1bea88,05685e2fb0179758783dbc49e74efab3,(***ERROR***)] [rxMD5:fa5776a1df54e92b8547eca1b00c42f6,f555afff0c4ef6d9b7eed7741a674c75,183fb08656621a86459ea2b7b8204e6c] 
POC    4 LId:  0 TId: 2 ( B-SLICE, QP 34 ) [DT  0.018] [L0 0 8] [L1 0c 8] [MD5:c2bbd04105f57c01f6e87c96fc4a1599,aba841bc7918bc6dd49ab9fc58e83f3a,6ef3b1d76c7f7427578331c9a6ed31bf,(***ERROR***)] [rxMD5:5da85ebe62f3bb2fafc3af5896b6f7a0,52544903e297e4557a65e574e686ad76,1f9e1f5a95bd9d578a4c96ec46474038] 
POC    2 LId:  0 TId: 3 ( B-SLICE, QP 34 ) [DT  0.016] [L0 0 4] [L1 0c 4] [MD5:c1229ee0bf6e07d66222d08fb8c32412,0b127ea49b908b069f89f36025428c20,a875941179c8048afe66719c0da82e7f,(***ERROR***)] [rxMD5:a43c15dc6a0eaeea5d341efb1873350f,8aaffa5b8d920824969b5340e6428b55,12b4368edfe987880ec3a78129082d77] 
POC    1 LId:  0 TId: 4 ( B-SLICE, QP 34 ) [DT  0.010] [L0 0 2] [L1 0c 2] [MD5:9036ac7b26902d3c0861afbdea9be014,6ef944716d56a7e95cac1bee7145e1d2,737ce2f38b92ae10c29efb51535886c5,(***ERROR***)] [rxMD5:1d198d6725c006f6a3aaf8225e75b18e,5b16dfbe3ac72adb9b1f0fdb160704ea,2632c92b9331ad8c64780e63d3da35ea] 

ERROR: In function "decompressSlice" in /Users/suehring/projects/git/VTM-Integration/VVCSoftware_VTM_ksuehring/source/Lib/DecoderLib/DecSlice.cpp:248: Expecting a terminating bit

 Total Time:        0.141 sec.

Already at POC 8 the decoder list 1 does not match: (16c 0) at the encoder vs. (0c 16) at the decoder.

[hendry197]

The problem seems to come from this code in the encoder:

if( m_intraPeriod < 0 )
{

sps.setRPL1CopyFromRPL0Flag( true );

}

That flag (i.e., the flag that specifies whether the RPL1 candidates are the same as RPL0 candidates) should not be set based on the length of intra period. More detail checking on RPL0 and RPL1 lists is needed to appropriately set the value of this flag.

MR !1434 has been submitted

[XiangLi]

Fixed in ​https://vcgit.hhi.fraunhofer.de/jvet/VVCSoftware_VTM/-/merge_requests/1434

[tung.nguyen]

Another problem occurs (e5e4c9a), SlideShow QP 37:

ERROR: In function "checkSTSA" in source/Lib/CommonLib/Slice.cpp:665: When the current picture is an STSA picture and nuh_layer_id equal to that of the current picture, there shall be no active entry in the RPL that has TemporalId equal to that of the current picture

[XiangLi]

Further fix in ​https://vcgit.hhi.fraunhofer.de/jvet/VVCSoftware_VTM/-/merge_requests/1440