Opened 4 years ago
Closed 4 years ago
#966 closed defect (fixed)
Incorrect mv clipping for subpictures in clipMv function
| Reported by: | hallapur | Owned by: | |
|---|---|---|---|
| Priority: | minor | Milestone: | VTM-8.1 |
| Component: | VTM | Version: | VTM-8.0 |
| Keywords: | Cc: | ksuehring, XiangLi, fbossen, jvet@… |
Description
This is mv clipping for subpictures in current master:
iHorMax = (curSubPic.getSubPicWidthInLumaSample() + iOffset - (int)pos.x - 1 ) << iMvShift;
iHorMin = (-(int)sps.getMaxCUWidth() - iOffset - ((int)pos.x - curSubPic.getSubPicLeft()) + 1) << iMvShift;
iVerMax = (curSubPic.getSubPicHeightInLumaSample()+ iOffset - (int)pos.y - 1) << iMvShift;
iVerMin = (-(int)sps.getMaxCUHeight() - iOffset - ((int)pos.y - curSubPic.getSubPicTop()) + 1) << iMvShift;
Computation of iHorMax and iVerMax does not take subpicture position into account. These should be correct formulas:
iHorMax = ((curSubPic.getSubPicRight() + 1) + iOffset - (int)pos.x - 1 ) << iMvShift;
iHorMin = (-(int)sps.getMaxCUWidth() - iOffset - ((int)pos.x - curSubPic.getSubPicLeft()) + 1) << iMvShift;
iVerMax = ((curSubPic.getSubPicBottom() + 1) + iOffset - (int)pos.y - 1) << iMvShift;
iVerMin = (-(int)sps.getMaxCUHeight() - iOffset - ((int)pos.y - curSubPic.getSubPicTop()) + 1) << iMvShift;
I will create merge request.
Change history (1)
comment:1 Changed 4 years ago by ksuehring
- Milestone set to VTM-8.1
- Resolution set to fixed
- Status changed from new to closed
- Version set to VTM-8.0
Fixed in MR 1464
https://vcgit.hhi.fraunhofer.de/jvet/VVCSoftware_VTM/-/merge_requests/1464