Opened 5 years ago
Closed 5 years ago
#984 closed defect (fixed)
Typo in writing Deblocking Cb, Cr Beta and Tc offsets in PictureHeader
| Reported by: | AnandMeher | Owned by: | |
|---|---|---|---|
| Priority: | minor | Milestone: | VTM-8.1 |
| Component: | VTM | Version: | |
| Keywords: | Cc: | ksuehring, XiangLi, fbossen, jvet@… |
Description
The following lines of code in function codePictureHeader have a typo.
WRITE_SVLC( picHeader->getDeblockingFilterBetaOffsetDiv2(), "ph_cb_beta_offset_div2" );
WRITE_SVLC( picHeader->getDeblockingFilterTcOffsetDiv2(), "ph_cb_tc_offset_div2" );
WRITE_SVLC( picHeader->getDeblockingFilterBetaOffsetDiv2(), "ph_cr_beta_offset_div2" );
WRITE_SVLC( picHeader->getDeblockingFilterTcOffsetDiv2(), "ph_cr_tc_offset_div2" );
They should instead use Cb and Cr get functions as follows:
WRITE_SVLC(picHeader->getDeblockingFilterCbBetaOffsetDiv2(), "ph_cb_beta_offset_div2");
WRITE_SVLC(picHeader->getDeblockingFilterCbTcOffsetDiv2(), "ph_cb_tc_offset_div2");
WRITE_SVLC(picHeader->getDeblockingFilterCrBetaOffsetDiv2(), "ph_cr_beta_offset_div2");
WRITE_SVLC(picHeader->getDeblockingFilterCrTcOffsetDiv2(), "ph_cr_tc_offset_div2");
Change history (2)
comment:1 Changed 5 years ago by ksuehring
comment:2 Changed 5 years ago by fbossen
- Resolution set to fixed
- Status changed from new to closed
The fix is submitted as MR 1518
https://vcgit.hhi.fraunhofer.de/jvet/VVCSoftware_VTM/-/merge_requests/1518