Opened 5 years ago

Closed 5 years ago

#113 closed defect (fixed)

memory issue with JVET_L0266_HMVP

Reported by: taoranlu Owned by:
Priority: minor Milestone: VTM-3.0
Component: VTM Version: VTM-3.0rc1
Keywords: Cc: ksuehring, XiangLi, fbossen, jvet@…

Description

Valgrind check on decoding report Mismatched free() / delete / delete [] in
Slice::destroyMotionLUTs() and Slice::initMotionLUTs()

Attached patch from Li Zhang can resolve this issue.

Attachments (1)

memory.patch​ (725 bytes) - added by taoranlu 5 years ago.

Download all attachments as: .zip

Change history (6)

Changed 5 years ago by taoranlu

comment:1 follow-up: Changed 5 years ago by fbossen

Thanks for the report. I fail to see how changing the init value of sameCandIdx in the patch solves anything.
​https://vcgit.hhi.fraunhofer.de/jvet/VVCSoftware_VTM/merge_requests/97

comment:2 in reply to: ↑ 1 Changed 5 years ago by LiZhang

Hi Frank,

The change of the init value of sameCandIdx was intended to fix one corner case for incorrect memory access for the following case:
lutMC->currCnt == MAX_NUM_HMVP_CANDS && pruned == false.

In this case, the number of motion candidates to be copied should be (MAX_NUM_HMVP_CANDS - 1). The original code will copy MAX_NUM_HMVP_CANDS candidates which is out of memory.

No impact on coding performance.

Replying to fbossen:

Thanks for the report. I fail to see how changing the init value of sameCandIdx in the patch solves anything.
​https://vcgit.hhi.fraunhofer.de/jvet/VVCSoftware_VTM/merge_requests/97

comment:4 Changed 5 years ago by ksuehring

  • Version set to VTM-3.0rc1

comment:5 Changed 5 years ago by fbossen

  • Resolution set to fixed
  • Status changed from new to closed
Note: See TracTickets for help on using tickets.