Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#1250 closed defect (fixed)

Editorial: naming inconsistency for CCALF-related syntax elements

Reported by: ochubach Owned by:
Priority: minor Milestone:
Component: spec Version: VVC D10 vE
Keywords: CCALF Cc: ksuehring, XiangLi, fbossen, jvet@…


At PH and SH-level, syntax elements related to CCALF are named as follows: _cc_alf_cb(cr)_, while in alf_data() the flags related to CCALF are called alf_cc_cb(cr)_. It is suggested to align naming rule for all syntax elements related to CCALF: use either cc_alf or alf_cc. Otherwise, such inconsistency creates confusion and makes searching for all SEs related to this tool difficult.

Change history (5)

comment:1 Changed 4 years ago by ochubach

  • Component changed from VTM to spec

comment:2 Changed 4 years ago by yk

  • Resolution set to fixed
  • Status changed from new to closed

Good suggestion to me for naming consistency. I just replaced all instances of "_cc_alf" with "_alf_cc" in the text being prepared for JVET-S2001-vF.

comment:3 Changed 4 years ago by asegall

The harmonization is definitely a good idea. However, since the tool is commonly called CCALF - I might suggest to go with "cc_alf" instead?

comment:4 Changed 4 years ago by yk

Andrew, I initially thought about doing that, too. However, then I noticed that all syntax elements in alf_data() start with "alf_".

If we use "cc_alf" we would either end up with "alf_cc_alf..." for the CCLAF syntax elements in alf_data(), or break the convention of all syntax elements in alf_data() starting with "alf_". I thus chose replacing "_cc_alf" with "_alf_cc". Most likely this was the same reason why CCALF syntax elements in alf_data() are currently in the form of "alf_cc...".

comment:5 Changed 4 years ago by asegall

Thanks, and works for me. Definitely not a deep concern on my side.

Note: See TracTickets for help on using tickets.