Opened 4 years ago
Closed 4 years ago
#1255 closed defect (fixed)
Editorial: variable used before being defined in sub-clause 8.8.3.5
Reported by: | LiZhang | Owned by: | |
---|---|---|---|
Priority: | minor | Milestone: | VVC D10 |
Component: | spec | Version: | VVC D10 vE |
Keywords: | Cc: | ksuehring, bbross, XiangLi, fbossen, jvet@… |
Description
Variables i, j are used before being defined.
In sub-clause 8.8.3.5, the following text are defined:
– If edgeType is equal to EDGE_VER,
xDi = ( i * gridSize ) (1228)
yDj = cIdx = = 0 ? ( j << 2 ) : ( j << 1 ) (1229)
...
– Otherwise (edgeType is equal to EDGE_HOR),
xDi = cIdx = = 0 ? ( i << 2 ) : ( i << 1 ) (1232)
yDj = j * gridSize (1233)
...
For xDi with i = 0..xN and yDj with j = 0..yN, the following applies:
– If edgeFlags[ xDi ][ yDj ] is equal to 0, the variable bS[ xDi ][ yDj ] is set equal to 0.
...
It may be better to derive xDi according to i = 0..xN and to derive yDj according to j = 0..yN.
Change history (4)
comment:1 Changed 4 years ago by jlchen
comment:2 Changed 4 years ago by LiZhang
It may be better to firstly derive xN and yN; followed by xDi and yDj.
How about:
"The variables xDi, yDj, xN and yN are derived as follows:" -->
"The variables xN and yN are derived as follows:"
Afterwards, add "The variables xDi with i = 0..xN, yDj with j = 0..yN are derived as follows:"
Move the xDi and yDj definitions here.
comment:3 Changed 4 years ago by jlchen
You're right. Will take your second solution in JVET-S2001-vF release.
comment:4 Changed 4 years ago by bbross
- Resolution set to fixed
- Status changed from new to closed
Good catch!
How about modified as follows:
"The variables xDi, yDj, xN and yN are derived as follows:" -->
"The variables xDi with i = 0..xN, yDj with j = 0..yN, xN and yN are derived as follows:"