Opened 5 years ago
Closed 5 years ago
#303 closed defect (fixed)
bug in virtual boundaries (N0438) code
| Reported by: | david.gommelet | Owned by: | |
|---|---|---|---|
| Priority: | major | Milestone: | VTM-5.1 |
| Component: | VTM | Version: | VTM-5.0 |
| Keywords: | Cc: | ksuehring, XiangLi, fbossen, jvet@… |
Description
Incorrect virtual boundary is used on chroma component Cr for SAO.
In SampleAdaptiveOffset.cpp line595 and in EnSampleAdaptiveOffset line319, the location of the virtual boundaries horVirBndryPos[] and verVirBndryPos[] are filled.
Then in the following "for" loop, these positions are used for the luma component, divided by two for the Cb component, and further divided by two for the Cr component.
This second division should not be applied.
For example, if an horizontal virtual boundary is set at position
32 for the luma component, the virtual boundary will be at position 16 for the Cb component and 8 for the Cr component. It should be 16 for Cb and Cr.
Change history (1)
comment:1 Changed 5 years ago by ksuehring
- Milestone set to VTM-5.1
- Resolution set to fixed
- Status changed from new to closed
Note: See TracTickets for help on using tickets.
A bug fix was submitted in MR599 and was merged
https://vcgit.hhi.fraunhofer.de/jvet/VVCSoftware_VTM/merge_requests/599