#304 closed defect (fixed)
Mismatch with spec on pps_virtual_boundaries_pos_x/y coding
Reported by: | forayr | Owned by: | |
---|---|---|---|
Priority: | minor | Milestone: | VTM-5.1 |
Component: | VTM | Version: | VTM-5.0 |
Keywords: | Cc: | ksuehring, XiangLi, fbossen, jvet@… |
Description
In spec:
The number of bits used to represent pps_virtual_boundaries_pos_x[ i ] is Ceil( Log2( pic_width_in_luma_samples ) − 3 ).
In vtm:
int numBits = 1; uint32_t picWidthDivBy8 = parameterSetManager->getSPS( pcPPS->getSPSId() )->getPicWidthInLumaSamples() >> 3; // pcPPS->getPicWidthInLumaSamples() >> 3; while( picWidthDivBy8 >>= 1 ) { numBits++; }
When pic_width_in_luma_samples = 128:
- numBits with spec calculation is Ceil(7 - 3) = Ceil(4) = 4
- numBits with vtm derivation is 5
Change history (3)
comment:1 Changed 6 years ago by forayr
comment:2 Changed 6 years ago by forayr
- Resolution set to fixed
- Status changed from new to closed
Fix was merged
comment:3 Changed 6 years ago by ksuehring
- Milestone set to VTM-5.1
Note: See TracTickets for help on using tickets.
Proposed fix: https://vcgit.hhi.fraunhofer.de/jvet/VVCSoftware_VTM/merge_requests/591