Opened 6 years ago

Closed 6 years ago

#328 closed defect (fixed)

Mismatch with spec on MaxBtSizeY, MaxTtSizeY, MinTtSizeY derivation (testing IRAP instead of slice_type)

Reported by: fbarbier Owned by:
Priority: minor Milestone:
Component: VTM Version: VTM-5.0
Keywords: Cc: ksuehring, XiangLi, fbossen, jvet@…

Description

The current implementation, in source/Lib/CommonLib/Slice.cpp, is using the fact that a slice is IRAP, instead of testing slice_type I_SLICE like in specification.

Please check functions like PreCalcValues::getValIdx (Slice.cpp:2820)

uint32_t PreCalcValues::getValIdx( const Slice &slice, const ChannelType chType ) const
{
  return slice.isIRAP() ? ( ISingleTree ? 0 : ( chType << 1 ) ) : 1;
}

Should be something like :

uint32_t PreCalcValues::getValIdx( const Slice &slice, const ChannelType chType ) const
{
  return slice.getSliceType() == I_SLICE ? ( ISingleTree ? 0 : ( chType << 1 ) ) : 1;
}

Change history (1)

comment:1 Changed 6 years ago by fbarbier

  • Resolution set to fixed
  • Status changed from new to closed

Fixed with commit 4ffa379bde22fb2764b52a48ee0cae3548794d5d

Note: See TracTickets for help on using tickets.