Opened 2 years ago

Closed 2 years ago

#375 closed defect (fixed)

JVET-O0105 ICT - QP for TuCResMode = 3

Reported by: bheng Owned by:
Priority: minor Milestone:
Component: VTM Version: VTM-5.2
Keywords: Cc: ksuehring, XiangLi, fbossen, jvet@…

Description

My understanding from the draft text is that, for TuCResMode=3 (cb_cbf=0, cr_cbf=1), the Cr QP is supposed to be used.

However, it appears that the decoder is using the Cb QP for this case.

I believe it could be fixed by adding something like the following lines to the QPParam constructor in Quant.cpp.

const bool useJQP = ( abs(TU::getICTMode(tu)) == 2 );
if(abs(TU::getICTMode(tu)) == 3)
{

compID = COMPONENT_Cr;

}

Change history (2)

comment:1 Changed 2 years ago by crhelmrich

Hi, thanks for spotting this. Indeed, the Cb QP was used in both the encoder and decoder, even though the Cr QP should be used in that case. I incorporated a fix for this in the existing JCCR related merge request !719, see
https://vcgit.hhi.fraunhofer.de/jvet/VVCSoftware_VTM/merge_requests/719/diffs?commit_id=899566635291dae14caf39d8d19755cd1c436831

Best,

Christian

comment:2 Changed 2 years ago by crhelmrich

  • Resolution set to fixed
  • Status changed from new to closed
Note: See TracTickets for help on using tickets.