Opened 2 years ago

Closed 2 years ago

#374 closed defect (fixed)

JVET-O0055 with DMVR SAD Doubled

Reported by: bheng Owned by:
Priority: minor Milestone: VVC D6 vD
Component: spec Version: VVC D6 vC
Keywords: Cc: ksuehring, bbross, XiangLi, fbossen, jvet@…

Description

The BDOF disable threshold in the VTM code

bioEnabledThres = 8 * (dy >> 1) * dx;

appears to match the threshold in the text:

(((sbHeight >> 2) * (sbWidth >> 2) * bdofBlkDiffThres) >> 5)

Unfortunately,the SAD value returned from xDMVRCost( ) in the VTM code appears to be doubled relative to what is specified in the draft text, Section 8.5.3.3.

Specifically, see function xGetSAD_NxN_SIMD() where the SAD is doubled at the following line:

uiSum <<= iSubShift;

Assuming it is desired to keep the behavior of the code, the threshold in the draft text probably needs to be reduced by a factor of 2 to give the same behavior.

Change history (2)

comment:1 Changed 2 years ago by bbross

  • Milestone set to VVC D6 vD

comment:2 Changed 2 years ago by bbross

  • Resolution set to fixed
  • Status changed from new to closed

Will be fixed in vD

Note: See TracTickets for help on using tickets.