Correcting in files for GCC 9.1.1 (libgomp) with WPP & SPLIT PARALLELISM

[Jamaika]

Picture.cpp

45:#include "mingw.condition_variable.h"

Reshape.cpp

42:#include "UnitTools.h"

Slice.cpp

1047: msg((MsgLevel) ERROR, "\nCurrent picture: %d Long-term reference picture with POC = %3d seems to have been removed or not correctly decoded.", this->getPOC(), notPresentPoc);
1078: msg((MsgLevel) ERROR, "\nCurrent picture: %d Short-term reference picture with POC = %3d seems to have been removed or not correctly decoded.", this->getPOC(), notPresentPoc);
1883: msg((MsgLevel) ERROR, "Error: no scaling list file specified. Help on scaling lists being output\n");
1891: msg((MsgLevel) ERROR, "Error: cannot open scaling list file %s for reading\n", fileName.c_str());
1924: msg((MsgLevel) ERROR, "Error: cannot find Matrix %s from scaling list file %s\n", MatrixType[sizeIdc][listIdc], fileName.c_str());
1933: msg((MsgLevel) ERROR, "Error: cannot read value #%d for Matrix %s from scaling list file %s at file position %ld\n", i, MatrixType[sizeIdc][listIdc], fileName.c_str(), ftell(fp));
1938: msg((MsgLevel) ERROR, "Error: QMatrix entry #%d of value %d for Matrix %s from scaling list file %s at file position %ld is out of range (0 to 255)\n", i, data, MatrixType[sizeIdc][listIdc], fileName.c_str(), ftell(fp));
1964: msg((MsgLevel) ERROR, "Error: cannot find DC Matrix %s from scaling list file %s\n", MatrixType_DC[sizeIdc][listIdc], fileName.c_str());
1971: msg((MsgLevel) ERROR, "Error: cannot read DC %s from scaling list file %s at file position %ld\n", MatrixType_DC[sizeIdc][listIdc], fileName.c_str(), ftell(fp));
1976: msg((MsgLevel) ERROR, "Error: DC value %d for Matrix %s from scaling list file %s at file position %ld is out of range (0 to 255)\n", data, MatrixType[sizeIdc][listIdc], fileName.c_str(), ftell(fp));

Picture.h

55:#include "mingw.mutex.h"

TypeDef.h

57:#define JVET_O0650_SIGNAL_CHROMAQP_MAPPING_TABLE 0 / / JVET-O0650: Signal chroma QP mapping tables and move chroma PPS/slice offsets after mapping table
194:#define JVET_O0280_SIMD_TRIANGLE_WEIGHTING 0 / / JVET-O0280: SIMD implementation for weighted sample prediction process of triangle prediction mode / / No SIMD
367:#define SIMD_ENABLE 0 / / No SIMD

DecLib.cpp

126: msg((MsgLevel) ERROR, "Warning: Attempt to decode an empty NAL unit\n");

VLCReader.cpp

2493: msg((MsgLevel) ERROR, "Trailing byte should be 0, but has value %02x\n", trailingNullByte);

DecLib.h

45:
46:#include "CommonLib/CacheModel.h"

EncCu.cpp

#include "CommonLib/MCTS.h"

EncSlice.cpp

1410: for( int ctuTsAddr = startCtuTsAddr; ctuTsAddr < boundingCtuTsAddr; ctuTsAddr += pcPic->cs->pcv->widthInCtus )
1417: encodeCtus( pcPic, bCompressEntireSlice, bFastDeltaQP, ctuTsAddr, ctuTsAddr + pcPic->cs->pcv->widthInCtus, m_pcLib );
1425: CHECK(cs.sps == 0, "No SPS present");
1426: writeBlockStatisticsHeader(cs.sps);

Analyze.h

483: msg((MsgLevel) ERROR, "Unknown format during print out\n");
536: msg((MsgLevel) ERROR, "Unknown format during print out\n");

EncHRD.h

38:#include "CommonLib/Common.h"
39:#include "CommonLib/HRD.h"
40:#include "CommonLib/Slice.h"

EncSlice.h

137: / /static

ColourRemapping.cpp

252: msg((MsgLevel) ERROR, "WARNING: crInputMatrixCoefficients set to MATRIX_COEFFICIENTS_RGB and crInputFullRangeFlag not set\n");
262: msg((MsgLevel) ERROR, "WARNING: crInputMatrixCoefficients set to undefined value: %d\n", crInputMatrixCoefficients);
271: msg( (MsgLevel) ERROR, "WARNING: crMatrixCoefficients set to MATRIX_COEFFICIENTS_RGB and crInputFullRangeFlag not set\n");
281: msg((MsgLevel) ERROR, "WARNING: crMatrixCoefficients set to undefined value: %d\n", crMatrixCoefficients);

DecoderApp.cpp

158: msg((MsgLevel) ERROR, "Warning: Attempt to decode an empty NAL unit\n");

DecAppCfg.cpp

125: msg((MsgLevel) ERROR
163: msg((MsgLevel) ERROR
169: msg((MsgLevel) ERROR
186: msg((MsgLevel) ERROR
197: msg((MsgLevel) ERROR
208: msg((MsgLevel) ERROR
214: msg((MsgLevel) ERROR

decmain.cpp

42:#include "Utilities/program_options_lite.h"

EnecAppCfg.cpp

1411: msg((MsgLevel) ERROR
1690: msg((MsgLevel) ERROR
1694: msg((MsgLevel) ERROR
1767: msg((MsgLevel) ERROR
3556: msg((MsgLevel) ERROR

789: ("InputBitDepth", m_inputBitDepth[CHANNEL_TYPE_LUMA], 0, "Bit-depth of input file")
1632: m_bitDepthConstraint = ((m_profile == Profile::MAINREXT | | m_profile == Profile::NEXT) ? 12 : 8);
2394: xConfirmPara(m_bitDepthConstraint != ((m_profile==Profile::MAINREXT | | m_profile==Profile::NEXT) ? 12 : 8), "BitDepthConstraint must be 8 for NEXT profile and 10/12 for MAINREXT profile.");

[ksuehring]

WPP & SPLIT PARALLELISM options are not really maintained. Patches are still appreciated, but may be worked on only with very low priority.

Some comments:

JVET_O macros are normative changes. These can't just be turned off.

55:#include "mingw.mutex.h"

seems very platform specific.

[ksuehring]

WPP/SPLIT parallel coding options were removed from the code. Closing as "won't fix"