Opened 6 years ago
Closed 6 years ago
#491 closed defect (fixed)
stack-use-after-scope in xIBCEstimation()
| Reported by: | ksuehring | Owned by: | |
|---|---|---|---|
| Priority: | major | Milestone: | VTM-6.1 | 
| Component: | VTM | Version: | VTM-6.0 | 
| Keywords: | Cc: | ksuehring, XiangLi, fbossen, jvet@… | 
Description
I found the following with libasan:
in void InterSearch::xIBCEstimation() is the follwing code:
  if ((pu.cs->slice->getLmcsEnabledFlag() && m_pcReshape->getCTUFlag()))
  {
    const CompArea &area = pu.blocks[COMPONENT_Y];
    CompArea    tmpArea(COMPONENT_Y, area.chromaFormat, Position(0, 0), area.size());
    PelBuf tmpOrgLuma = m_tmpStorageLCU.getBuf(tmpArea);
    tmpOrgLuma.copyFrom(tmpPattern);
    tmpOrgLuma.rspSignal(m_pcReshape->getFwdLUT());
    pcPatternKey = (CPelBuf*)&tmpOrgLuma;
  }
pcPatternKey is used later on, although tmpArea has been cleaned up by leaving the definition scope.
Change history (3)
comment:1 Changed 6 years ago by ksuehring
comment:2 Changed 6 years ago by ksuehring
Update: This does not fix #490 :(
comment:3 Changed 6 years ago by ksuehring
- Milestone set to VTM-6.1
 - Resolution set to fixed
 - Status changed from new to closed
 
The MR was merged
Note: See TracTickets for help on using tickets.
    
A possible fix is submitted as
https://vcgit.hhi.fraunhofer.de/jvet/VVCSoftware_VTM/merge_requests/885
may fix #490