Opened 2 weeks ago

Closed 8 days ago

#651 closed defect (fixed)

JVET-P0091: Reduction of BDOF mvRefineThres to +/- 15

Reported by: bheng Owned by:
Priority: minor Milestone:
Component: spec Version: VVC D7 vB
Keywords: Cc: ksuehring, XiangLi, fbossen, jvet@…

Description

JVET-P0091 code changes have reduced the BDOF mvRefineThres to +/- 15, here:

#if JVET_P0091_REMOVE_BDOF_OFFSET_SHIFT

const int limit = ( 1 << 4 ) - 1;

#else

const int limit = ( 1 << 5 ) - 1;

#endif

The draft text still uses +/- 31:

"The variable mvRefineThres is set equal to 1 << 5."

It's not clear if that was intentional, or maybe an unintentional interaction with other changes to the code in the same place (P0653 / P0491).

If it was intentional, the text should be updated to match. If it was not intentional, this change in the software should be removed.

Change history (4)

comment:1 Changed 2 weeks ago by hanhuang

The modification is intentional. " P0091: BDOF and PROF unification by moving 1-bit right-shift of calculating the BDOF sample offset to the derivation of motion refinement". So the range of motion refinement in BDOF need to be adjusted.

comment:2 Changed 2 weeks ago by ksuehring

  • Component changed from VTM to spec
  • Version changed from VTM-7.0rc1 to VVC D7 vB

Changing the component to spec.

comment:3 Changed 2 weeks ago by bbross

Thanks for bringing that up.
Hence, I will fix it by changing:
"The variable mvRefineThres is set equal to 1 << 5."
to
"The variable mvRefineThres is set equal to 1 << 4."

comment:4 Changed 8 days ago by bbross

  • Resolution set to fixed
  • Status changed from new to closed

Fixed it as stated above for JVET-P2001-vC.

Note: See TracTickets for help on using tickets.