Opened 5 years ago
Closed 5 years ago
#652 closed defect (fixed)
Misleading variable names in TSRC sections
Reported by: | jonathang | Owned by: | |
---|---|---|---|
Priority: | minor | Milestone: | |
Component: | spec | Version: | VVC D7 vB |
Keywords: | Cc: | ksuehring, bbross, XiangLi, fbossen, jvet@… |
Description
In section 7.3.9.11 residual_ts_coding syntax table, I suggest replacing
if( BdpcmFlag[ x0 ][ y0 ][ cIdx ] = = 0 && n <= lastScanPosPass1 ) { absRightCoeff = xC > 0 ? AbsLevel[ xC − 1 ][ yC ] ) : 0 absBelowCoeff = yC > 0 ? AbsLevel[ xC ][ yC − 1 ] ) : 0 predCoeff = Max( absRightCoeff, absBelowCoeff )
with
if( BdpcmFlag[ x0 ][ y0 ][ cIdx ] = = 0 && n <= lastScanPosPass1 ) { absLeftCoeff = xC > 0 ? AbsLevel[ xC − 1 ][ yC ] ) : 0 absAboveCoeff = yC > 0 ? AbsLevel[ xC ][ yC − 1 ] ) : 0 predCoeff = Max( absLeftCoeff, absAboveCoeff )
In section 9.3.4.2.10, I suggest replacing
The variables rightSign and belowSign are set as follows: rightSign = ( xC = = 0 ) ? 0 : CoeffSignLevel[ xC − 1 ][ yC ] (9-58) belowSign = ( yC = = 0 ) ? 0 : CoeffSignLevel[ xC ][ yC − 1 ] (9-59) The variable ctxInc is derived as follows: – If rightSign is equal to 0 and belowSign is equal to 0, or if rightSign is equal to −belowSign, the following applies: ctxInc = ( BdpcmFlag[ x0 ][ y0 ][ cIdx ] = = 0 ? 0 : 3 ) (9-60) – Otherwise, if rightSign is greater than or equal to 0 and belowSign is greater than or equal to 0, the following applies:
with
The variables leftSign and aboveSign are set as follows: leftSign = ( xC = = 0 ) ? 0 : CoeffSignLevel[ xC − 1 ][ yC ] (9-58) aboveSign = ( yC = = 0 ) ? 0 : CoeffSignLevel[ xC ][ yC − 1 ] (9-59) The variable ctxInc is derived as follows: – If leftSign is equal to 0 and aboveSign is equal to 0, or if leftSign is equal to −aboveSign, the following applies: ctxInc = ( BdpcmFlag[ x0 ][ y0 ][ cIdx ] = = 0 ? 0 : 3 ) (9-60) – Otherwise, if leftSign is greater than or equal to 0 and aboveSign is greater than or equal to 0, the following applies:
Change history (1)
comment:1 Changed 5 years ago by bbross
- Resolution set to fixed
- Status changed from new to closed
Note: See TracTickets for help on using tickets.
Thanks for reporting.
This will be fixed JVET-P2001-vC.