Opened 23 months ago

Last modified 22 months ago

#734 new defect

VTM-7.0 has enc/dec mismatch for RPR 1.5x

Reported by: luoda Owned by:
Priority: minor Milestone:
Component: VTM Version: VTM-7.0
Keywords: Cc: ksuehring, XiangLi, fbossen, jvet@…

Description

Some RPR 1.5x tests have encoder-decoder mismatches.
The mismatches occur for either JVET_P0088_P0353_RPR_FILTERS is 0 or 1, so it doesn't seem like related to the filter.

Attachments (1)

fix_RPR.diff (4.5 KB) - added by Vadim 23 months ago.

Download all attachments as: .zip

Change history (9)

comment:1 follow-up: Changed 23 months ago by XiangLi

Thanks for the report. Could you provide detailed encoding settings and coding logs so that we could duplicate the issue?

comment:2 in reply to: ↑ 1 Changed 23 months ago by luoda

Command line that I used:

EncoderApp -c cfg/encoder_lowdelay_vtm.cfg -c cfg/per-class/classF.cfg -c cfg/per-sequence/SlideShow.cfg -c cfg/rpr/scale1.5x.cfg --IntraPeriod=-1 --SEIDecodedPictureHash=1 --PrintHexPSNR=1 --FramesToBeEncoded=500 -q 37 --InputFile=../SlideShow_1280x720_20.yuv -b SlideShow_QP37.bin -o rec.yuv

In addition, the problem may be introduced by

2ccf7dd6 (HEAD, tag: VTM-7.0) Merge branch 'RPR_PIC_SIZE_CLEANUP' into 'master'

I rolled back to the version before this commit and there is no mismatch in this test. But I didn't run a full test to verify it yet.

Replying to XiangLi:

Thanks for the report. Could you provide detailed encoding settings and coding logs so that we could duplicate the issue?

comment:3 Changed 23 months ago by Vadim

Rolling back is not a solution, since it introduces undefined picture width and height for the scaled reference pictures as mentioned in #688.

Changed 23 months ago by Vadim

comment:4 Changed 23 months ago by Vadim

Can you please try the attached patch? It is VTM-7.0 based.

comment:5 Changed 22 months ago by luoda

Yes. I confirmed that the patch fixed the problem. Thanks Vadim.

comment:6 Changed 22 months ago by ksuehring

It seems that parts of this have been added to the scalable implementation, but others are not yet in the software. Could you please create a merge request for the fix?

comment:7 Changed 22 months ago by bbross

Ticket #787 has been marked as a duplicate of this ticket.

comment:8 Changed 22 months ago by Vadim

I think this fix is not needed for VTM master branch since picture size is not used for tool control there. What part of the fix is still required?

Note: See TracTickets for help on using tickets.